Closed
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
pebrc
reviewed
Dec 30, 2025
Collaborator
pebrc
left a comment
pebrc
left a comment
There was a problem hiding this comment.
Apologies for the very late response to your contribution.
I think
cloud-on-k8s/pkg/controller/kibana/securitycontext.go
Lines 13 to 23 in 93406ed
Any reason you did not include it?
| Privileged: ptr.To[bool](false), | ||
| ReadOnlyRootFilesystem: ptr.To[bool](false), | ||
| AllowPrivilegeEscalation: ptr.To[bool](false), | ||
| SeccompProfile: &corev1.SeccompProfile{ |
Collaborator
There was a problem hiding this comment.
Indentation seems off here and below.
Collaborator
There was a problem hiding this comment.
Maybe add a test case for v8.8+
Contributor
|
Closed in favor of #9012 |
Author
Thanks for picking up and finishing this. I didn't see the review come through a month ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #7167, this is recommended for security reasons.
Before this change it is not possible to deploy on a cluster that is in restricted mode as there is not way to modify the securityContext on the initContainers that are automatically created.
If you would prefer, I can change it to allow the user to set the securityContext on those initcontainers instead of setting this as the default.